This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Reuse HTTP client instance #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaysoky Mind running a build of this, and seeing if it solves the problem? |
| @@ -226,6 +225,7 @@ func (rg *RecordGenerator) loadFromMaster(ip string, port string) (state.State, | |||
| } | |||
|
|
|||
| req.Header.Set("Content-Type", "application/json") | |||
| req.Header.Set("User-Agent", "Mesos-DNS") | |||
|
@jdef Looks good otherwise? The only thing I was thinking of is adding the PID to the user agent. What do you think? |
|
@sargun LGTM; no pid needed (too leaky) |
-Reuse HTTP client (pool) instance -Set user agent
gpaul
pushed a commit
that referenced
this pull request
Feb 1, 2017
Bumped to the following commit commit 99f84ae56e75126dd77e5de4fae2ea034a468ca1 Author: Matthijs Mekking <[email protected]> Date: Mon Jan 30 11:53:01 2017 +0100 return errTruncated after setting header bits (#442)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.