fixes #1106 - Return empty HealthCheck result instead of None, when no r...

[drexin]

...esults are present

[sttts]

Doesn't this change the semantics of the "alive" value of the health check result? When a task has not received any health result with this patch, the /apps endpoint will return a health check result with alive=true, won't it?

[sttts]

In other words, we either have the Option[Health] type or we have to change the type of alive from Boolean to Option[Boolean].

[bobrik]

Related to #940 too.

[drexin]

@sttts You're right. Closing this until I find a better solution.

[drexin]

Hm... Actually if it doesn't have a lastFailure set, you can be sure that it has never been healthy, so setting healthy = false should be okay.

[sttts]

Only alive is misleading. In the json we can set alive=null, in the code alive: Option[Boolean].

[drexin]

alive = false is correct, because it has never been alive. I think firstFailure = null should be enough to determine that it just didn't fully start yet.

[sttts]

Got what you mean. alive=false is better than healthy=false.

[sttts]

What is the opinion here?

My feeling is that the new semantics of alive=false + lastFailure=null is a bit complicated, but makes sense on the second thought.

[drexin]

@ConnorDoyle Could you please review?