-
Notifications
You must be signed in to change notification settings - Fork 843
Clearing the last item in a duplicable list #2120
Comments
We could dimm the button, if both row fields are completely empty. |
@philipnrmn can you provide a screenshot please? I don't see any dimming on marathon-latest. |
Hey @aatumanova, you won't see it because although it was implemented, it was then reverted, hence this issue. Here's a video of how it looked: |
Thanks for the video @philipnrmn! Here's an idea for how to make it obvious that when there is a single row, it cannot be removed — but the contents of the row can be cleared. Thoughts? Single row: http://cl.ly/image/1Z142b0R211W |
@aatumanova i really like the (x) for the last remaining row case, but why break the line for the (+) button? |
@pierlo-upitup thought was:(+) after the list feels like a more natural placement, because this is where the new row will appear. |
The I was confused by two different button colours: white for the |
@air reasoning for the green was that it's an adding action, so more "positive". Green is visually used for positive actions — success, healthy, good. That said, we're changing colors as I speak in the new designs for the epics Chad and I are working through, so I would suggest using white for the (+). |
Fixed in mesosphere/marathon-ui#95 |
Background: #950 (comment)
This request was implemented in mesosphere/marathon-ui#162 but is now slated for reversion because it disabled useful functionality, viz. removing the last environment variable in the list without manually clearing the text fields.
We should find a solution that makes it clear to the user that the last field cannot be removed from the list but retains the ability to clear the last field when it is populated.
@aatumanova @air what is your opinion here?
The text was updated successfully, but these errors were encountered: