Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Clearing the last item in a duplicable list #2120

Closed
philipnrmn opened this issue Aug 28, 2015 · 9 comments
Closed

Clearing the last item in a duplicable list #2120

philipnrmn opened this issue Aug 28, 2015 · 9 comments
Milestone

Comments

@philipnrmn
Copy link
Contributor

Background: #950 (comment)

decrease opacity to 50% on the "(–)" icon when editing the last remaining row of a duplicable set of values (disabled state)

This request was implemented in mesosphere/marathon-ui#162 but is now slated for reversion because it disabled useful functionality, viz. removing the last environment variable in the list without manually clearing the text fields.

We should find a solution that makes it clear to the user that the last field cannot be removed from the list but retains the ability to clear the last field when it is populated.

@aatumanova @air what is your opinion here?

@aldipower
Copy link
Contributor

We could dimm the button, if both row fields are completely empty.
If there are values in the row, don't dimm, because I probably want to remove this values.

@philipnrmn philipnrmn changed the title Last item in duplicable list should e Clearing the last item in duplicable list Aug 28, 2015
@philipnrmn philipnrmn changed the title Clearing the last item in duplicable list Clearing the last item in a duplicable list Aug 28, 2015
@aatumanova
Copy link
Contributor

@philipnrmn can you provide a screenshot please? I don't see any dimming on marathon-latest.

@philipnrmn
Copy link
Contributor Author

Hey @aatumanova, you won't see it because although it was implemented, it was then reverted, hence this issue.

Here's a video of how it looked:
http://cl.ly/2h1A2z2M2X0X

@aatumanova
Copy link
Contributor

Thanks for the video @philipnrmn!

Here's an idea for how to make it obvious that when there is a single row, it cannot be removed — but the contents of the row can be cleared. Thoughts?

Single row: http://cl.ly/image/1Z142b0R211W
Two rows: http://cl.ly/image/2h3V3d1K2d3A
Four rows: http://cl.ly/image/0E0f1s0D222a

cc @aldipower @ashenden

@pierluigi
Copy link

@aatumanova i really like the (x) for the last remaining row case, but why break the line for the (+) button?

@aatumanova
Copy link
Contributor

@pierlo-upitup thought was:(+) after the list feels like a more natural placement, because this is where the new row will appear.

@air
Copy link
Contributor

air commented Sep 14, 2015

The X is good.

I was confused by two different button colours: white for the X but green for the +.

@aatumanova
Copy link
Contributor

@air reasoning for the green was that it's an adding action, so more "positive". Green is visually used for positive actions — success, healthy, good.

That said, we're changing colors as I speak in the new designs for the epics Chad and I are working through, so I would suggest using white for the (+).

@aquamatthias aquamatthias added this to the 0.12.0 milestone Sep 23, 2015
@mwasn mwasn modified the milestones: 0.13.0, 0.12.0 Sep 28, 2015
@philipnrmn
Copy link
Contributor Author

Fixed in mesosphere/marathon-ui#95

@d2iq-archive d2iq-archive locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants