Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when parsing a line height with "auto" value #57

Open
d01000100 opened this issue Jul 25, 2023 · 0 comments
Open

Fails when parsing a line height with "auto" value #57

d01000100 opened this issue Jul 25, 2023 · 0 comments
Labels
bug Something isn't working mobile-outputs

Comments

@d01000100
Copy link
Owner

On version 0.2.0-alpha.3 When parsing this file there's an error on the parsings for mobile when transforming a line height value:

[15:02:38.264 - Event] Setting up mobile globals
[15:02:38.265 - Event] Token Transform
[token-transformer] transforming tokens from input: ./tokens-studio.json
[token-transformer] using sets: []
[token-transformer] using excludes: []
[token-transformer] using options: { expandTypography: true, expandShadow: true, expandComposition: false, expandBorder: false, preserveRawValue: false, resolveReferences: true }
[token-transformer] writing tokens to output: /var/folders/wj/tz_vd6ns30jg2d34fy3_yztm0000gn/T/tmp-44946-HhEU3AsyNNAM
[token-transformer] done transforming
✅ Done using token-transform
[15:02:38.452 - Event] Style Dictionary

compose
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Invalid Number: 'lineHeights1: auto' is not a valid number, cannot transform to 'rem' 
".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Most likely, this is happening on the transforms to dp, that are not checking if the values are numeric or not.

@d01000100 d01000100 added the bug Something isn't working label Jul 25, 2023
@d01000100 d01000100 added this to the Mobile outputs milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mobile-outputs
Projects
None yet
Development

No branches or pull requests

1 participant