Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateAnnotation to D2Reader instance properties #829

Closed
MooDySmiles opened this issue Mar 22, 2024 · 0 comments · Fixed by #839
Closed

Add updateAnnotation to D2Reader instance properties #829

MooDySmiles opened this issue Mar 22, 2024 · 0 comments · Fixed by #839

Comments

@MooDySmiles
Copy link

It would be helpful if there would be the possibility to call annotationModule.updateAnnotation directly from the d2Reader instance returned from D2Reader.load() method.

In my use case, I use a custom web component to show a modal where the user can type the note to add to an annotation, and such modal doesn't work like the SweetAlert library in the example of this repo, so I can't suspend the execution of addAnnotation or addCommentToAnnotation callback defined in the annotations.api config property.

Adding a public direct call to annotationModule.updateAnnotation (like it is for addAnnotation and `deleteAnnotation) would help me correctly handle the flow of my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant