Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature : Add Azure Active directory authentication when using Azure postgresql servers #37

Open
younux opened this issue Jan 15, 2021 · 5 comments

Comments

@younux
Copy link

younux commented Jan 15, 2021

Hello,
Is it possible to add a new feature to the provider : Connecting to Azure database postgresql using Azure Active DIrectory authentication as described here
The idea is that the password is a token that is fetched from Azure active directory using clientSecretCrentials.
I have already forked the project and implement this feature, I can make a pull request if you are ok to add this feature to this provider.
What do you think about it ?
Thanks for your feedback

@cyrilgdn
Copy link
Owner

cyrilgdn commented Feb 2, 2021

Hi @younux ,

Thanks for opening this issue (and sorry for the response delay, I missed some notifications from Github 🤦‍♂️ )

Yes we could be interested by this feature, it depends of the implementation.
Could you open the PR so I can see how it looks?

Thanks for your work on that!

@cyrilgdn cyrilgdn added the waiting-response Further information is requested label Feb 2, 2021
@SemMulder
Copy link

Hi @cyrilgdn and @younux,

I am also interested in this!

I checked the branch @younux wrote and saw he was using a different approach than the azurerm and azuread Terraform providers. To make it easy to use for people already using either of those I thought it would be nice if the postgres provider supported the exact same way of configuration, especially because there are a lot of ways to authenticate with Azure (client secrets, managed identities, via the az cli, etc.). That's why I started a new branch here: https://github.com/SemMulder/terraform-provider-postgresql/tree/add-aad-authentication. I hope to have an initial working version later this week.

Just a heads up to prevent possible duplicate work :)

@younux
Copy link
Author

younux commented Feb 11, 2021

Hello @SemMulder

The approach I used is for addressing the problem with the simplest possible way : easy to use and easy to understand (KISS principle).

I am not against your approach if is accepted. The important for me is to support this use case.

Regards,

@mathiasbecher
Copy link

Hi, @younux, @SemMulder

Is anyone still working on this feature?

@tspearconquest
Copy link
Contributor

Looks like this can be closed as the provider supports this. Not sure when it was added but I can see it in the documentation and examples online as well.

@github-actions github-actions bot removed the waiting-response Further information is requested label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants