Inactive git pre-commit Husky hook

[MikeMcC399]

Problem description

The git husky hook in https://github.com/cypress-io/github-action/blob/master/package.json is not being triggered:

  "husky": {
    "hooks": {
      "pre-commit": "npm run format && npm run build && git add index.js dist"
    }
  }

when changes are made to index.js they are not automatically causing dist/index.js to be updated, making the changes practically ineffective.

• Renovate PR chore(deps): update dependency husky to v7 #397 updated husky from 4.3.8 to 7.0.4.

Husky v5.0.0 introduced breaking changes, including the fact that it no longer autoinstalls.

It seems that when Husky was updated from v4 to v7 there was no reconfiguration done in the repo.

Suggested change

To re-activate Husky would require following the migration steps (see https://typicode.github.io/husky/).

I found two disadvantages of doing this:

1. Windows (CRLF) and Unix (LF) have incompatible line-ending formats so if commits are being done from different sources, then the format of dist/index.js would yoyo back and forwards (see Option to force Unix style output on Windows? vercel/ncc#992). The pre-commit hook would run independently of whether there had been a change to index.js and would therefore be applied to unrelated commits.
2. GitHub Desktop (for Windows) may fail using Husky (see https://github.com/desktop/desktop/issues).

So I suggest instead to remove the Husky configuration and solve the issue through:

1. Added documentation Incomplete build instructions in DEVELOPMENT.md #742
2. Implementation of Add build & diff "/dist" folder workflow #706

[MikeMcC399]

If the Husky hook were to be reactivated, users on Windows could avoid issues by setting the environment variable
HUSKY=0
See Husky documentation Bypass hooks.

[MikeMcC399]

Husky 8 is more flexible in defining the hook contents, so it would be possible to commit a changed dist/ directory content only if it had changed, ignoring the end-of-line characters.

[MikeMcC399]

• PR fix: windows build with ping.js #836 resolves the issue of build differences between Windows and unix. Once this PR is merged, the path is ready for the Husky pre-commit hook to be reactivated.

[MikeMcC399]

• PR ci: update to husky 8.0.3 and reactivate hook #839 is then the main PR to resolve this issue