feat: add env input - #25 #28
Conversation
|
|
README.md
Outdated
| env: host=api.dev.local,port=4222 | ||
| ``` | ||
|
|
||
| For more information, visit [the Cypress command-line docs](https://docs.cypress.io/guides/guides/command-line.html#cypress-run-env-lt-env-gt). |
There was a problem hiding this comment.
just a tip: to keep links working we use on.cypress.io redirects, which are usually just title of the page (plus any hashes). So this link would be more stable as https://on.cypress.io/command-line#cypress-run-env-lt-env-gt
| // TODO should env be quoted? | ||
| // If it is a JSON, it might have spaces | ||
| cmd.push('--env') | ||
| cmd.push(envInput) |
There was a problem hiding this comment.
hmm, yes, might need quotes, maybe single quotes, ughh, will require testing across OS
There was a problem hiding this comment.
When entering JSON it should already be wrapped in it's own string right?
For now do you think we should add a note to the README about potential issues or did you want to improve the handling/testing before releasing it?
|
I’m good with it as is - if users find a problem we will fix it :)
…Sent from my iPhone
On Nov 19, 2019, at 17:40, Scott Prue ***@***.***> wrote:
@prescottprue commented on this pull request.
In dist/index.js:
> @@ -1907,6 +1907,14 @@ const runTests = () => {
cmd.push(browser)
}
+ const envInput = core.getInput('env')
+ if (envInput) {
+ // TODO should env be quoted?
+ // If it is a JSON, it might have spaces
+ cmd.push('--env')
+ cmd.push(envInput)
When entering JSON it should already be wrapped in it's own string right?
For now do you think we should add a note to the README about potential issues or did you want to improve the handling/testing before releasing it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
envinput (closes cypress-io/actions #25)