Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not format fixture on run #924

Merged
merged 5 commits into from
Nov 16, 2017
Merged

Conversation

bahmutov
Copy link
Contributor

Stop formatting and saving fixtures. Let the users use their own favorite formatting tools.

@bahmutov bahmutov requested a review from brian-mann November 16, 2017 20:33
@bahmutov bahmutov merged commit a888f89 into develop Nov 16, 2017
@jennifer-shehane
Copy link
Member

No review? 😢 I am curious to know what the experience is like now if I have a formatting error in a fixture file, that I then specify to cy.fixture('user') or cy.route('/user', 'fx:user')

@bahmutov
Copy link
Contributor Author

well, we have unit tests for that, so it still reports if there is parsing error. But there is no such thing as formatting error!

MarcLoupias added a commit to MarcLoupias/cypress-documentation that referenced this pull request Nov 18, 2017
MarcLoupias added a commit to MarcLoupias/cypress-documentation that referenced this pull request Nov 18, 2017
brian-mann pushed a commit to cypress-io/cypress-documentation that referenced this pull request Nov 20, 2017
@jennifer-shehane jennifer-shehane deleted the do-not-format-fixture-on-run branch July 24, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants