Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e tests in both Chrome and Electron #5359

Merged
merged 35 commits into from
Oct 17, 2019
Merged

Run e2e tests in both Chrome and Electron #5359

merged 35 commits into from
Oct 17, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 11, 2019 •
edited by brian-mann
Loading

User facing changelog

N/A - not user facing

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@flotwig flotwig force-pushed the issue-5357-run-e2e-tests-in-all-browsers branch from 44648ed to b0f6a17 Compare October 11, 2019 19:28
@brian-mann
Merge branch 'develop' into issue-5357-run-e2e-tests-in-all-browsers
c779902
@brian-mann
WIP: create multiple tests per browser, but utilizing the same base s…
08127df 
…napshot

- create a dynamic test title with browser appended
- use a base named snapshot without the browser name appended
- patch snap-shot-it not to rethrow twice unnecessarily which ends up
throwing the wrong error
@bahmutov
Copy link
Contributor

I have opened bahmutov/snap-shot-it#443 to allow multiple tests to "share" a named snapshot

@bahmutov
Copy link
Contributor

I have published [email protected] which implements shared named snapshots, see bahmutov/snap-shot-it@cad8ad6

snapshot('my shared snapshot', value, { allowSharedSnapshot : true })

@flotwig flotwig force-pushed the issue-5357-run-e2e-tests-in-all-browsers branch from bc90d5f to 450c693 Compare October 15, 2019 21:56
brian-mann
brian-mann requested changes Oct 16, 2019
View reviewed changes
circle.yml Outdated Show resolved Hide resolved
packages/server/__snapshots__/0_simple_spec.js Outdated Show resolved Hide resolved
packages/server/test/e2e/0_simple_spec.js Outdated Show resolved Hide resolved
@flotwig flotwig force-pushed the issue-5357-run-e2e-tests-in-all-browsers branch from 32d1708 to 9055741 Compare October 16, 2019 17:11
@flotwig flotwig changed the title [WIP] Run e2e tests in both Chrome and Electron Run e2e tests in both Chrome and Electron Oct 16, 2019
flotwig and others added 2 commits October 16, 2019 17:54
@flotwig
Use e2e.it for chrome/electron-specific tests
44b9992
@brian-mann
handle logic for skipping tests when default browsers do not match sp…
ba62c27 
…ecified browser

- implement e2e.it.skip to match mocha’s it.skip
- allow turning off dynamic test generation
@brian-mann brian-mann merged commit 561bd21 into develop Oct 17, 2019
@cypress-bot cypress-bot bot mentioned this pull request Oct 17, 2019
Closed
brian-mann
brian-mann reviewed Oct 17, 2019
View reviewed changes
Copy link
Member

@brian-mann brian-mann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@flotwig flotwig deleted the issue-5357-run-e2e-tests-in-all-browsers branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann brian-mann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run e2e tests in all browsers by default
4 participants
@flotwig @bahmutov @brian-mann @jennifer-shehane