Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade [email protected] -> 2.0.0 #3867

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Downgrade [email protected] -> 2.0.0 #3867

merged 2 commits into from
Apr 2, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 2, 2019

Fixes #3717

A regression in parse-domain since 2.1.0 is causing tests to fail for some users with public suffixes. This will add a unit test for the behavior that is broken to ensure we don't accidentally upgrade as well as reverts it back to 2.0.0.

@flotwig flotwig changed the title [WIP] Downgrade [email protected] -> 2.0.0 Downgrade [email protected] -> 2.0.0 Apr 2, 2019
@flotwig flotwig requested a review from a team April 2, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught DOMException: Failed to set the 'domain' property on 'Document': 'gouv.fr' is a top-level domain.
2 participants