From 619858bac302319d2c5866690d1fe472ca2c35e4 Mon Sep 17 00:00:00 2001
From: mjhenkes <mjhenkes@gmail.com>
Date: Wed, 17 May 2023 09:33:09 -0500
Subject: [PATCH] chore: telemetry pr cleanup

---
 packages/proxy/lib/http/request-middleware.ts                   | 2 --
 .../telemetry/src/span-exporters/console-trace-link-exporter.ts | 2 +-
 ...nsDetectorSync.spec.ts => githubActionsDetectorSync.spec.ts} | 0
 3 files changed, 1 insertion(+), 3 deletions(-)
 rename packages/telemetry/test/detectors/{ghithubActionsDetectorSync.spec.ts => githubActionsDetectorSync.spec.ts} (100%)

diff --git a/packages/proxy/lib/http/request-middleware.ts b/packages/proxy/lib/http/request-middleware.ts
index 8405033a8657..dbdb797b231e 100644
--- a/packages/proxy/lib/http/request-middleware.ts
+++ b/packages/proxy/lib/http/request-middleware.ts
@@ -108,7 +108,6 @@ const MaybeAttachCrossOriginCookies: RequestMiddleware = function () {
 
   const doesTopNeedSimulation = doesTopNeedToBeSimulated(this)
 
-  // TODO: might not need these on the span as they are declared above and might trickle down
   span?.setAttributes({
     doesTopNeedToBeSimulated: doesTopNeedSimulation,
     resourceType: this.req.resourceType,
@@ -318,7 +317,6 @@ const RedirectToClientRouteIfUnloaded: RequestMiddleware = function () {
 
     span?.end()
 
-    // TODO: where is this? Do we need to pass the span in here?
     return this.end()
   }
 
diff --git a/packages/telemetry/src/span-exporters/console-trace-link-exporter.ts b/packages/telemetry/src/span-exporters/console-trace-link-exporter.ts
index 9c65e1cea0df..0bfd714d703e 100644
--- a/packages/telemetry/src/span-exporters/console-trace-link-exporter.ts
+++ b/packages/telemetry/src/span-exporters/console-trace-link-exporter.ts
@@ -41,7 +41,7 @@ export class ConsoleTraceLinkExporter implements SpanExporter {
             this._uniqueTraces[traceId] = spanId
 
             this._log(
-            `Trace start: [${span.name}] - ${this._traceUrl}=${span.spanContext().traceId}`,
+              `Trace start: [${span.name}] - ${this._traceUrl}=${span.spanContext().traceId}`,
             )
           }
         } else if (this._uniqueTraces[traceId] === spanId) {
diff --git a/packages/telemetry/test/detectors/ghithubActionsDetectorSync.spec.ts b/packages/telemetry/test/detectors/githubActionsDetectorSync.spec.ts
similarity index 100%
rename from packages/telemetry/test/detectors/ghithubActionsDetectorSync.spec.ts
rename to packages/telemetry/test/detectors/githubActionsDetectorSync.spec.ts