feat: Trash downloads folder before runs

[chrisbreiding]

• Addresses TR-602
• Addresses In-browser file download support #949

User facing changelog

Not sure if this needs its own changelog item, as it's just a corollary to #14431. This might actually be considered a chore rather than a feature.

Additional Details

With #14431, users can test out file downloads. With this, the downloads folder will be trashed along with screenshots and videos before a run unless trashAssetsBeforeRuns is false.

PR Tasks

• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation? File download updates cypress-documentation#3472
• N/A Have API changes been updated in the type definitions?
• N/A Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

9193 • 0 • 118 • 3

---

Run details

Project	cypress
Status	Passed
Commit	aeff642
Started	Jan 11, 2021 6:43 PM
Ended	Jan 11, 2021 6:57 PM
Duration	13:31 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

I wonder how many users will want to auto-trash screenshots and videos, but not downloads, or vice versa. We could extend trashAssetsBeforeRuns to accept boolean | { screenshots?: boolean, videos?: boolean, downloads?: boolean }.

But I guess that's probably not worth the effort, since the user can always add a plugin event to use fs to delete whatever they want between tests, and it's a rare use case.

Is there an existing docs PR for this? It looks like trashAssetsBeforeRuns docs will need an update:

[chrisbreiding]

I wonder how many users will want to auto-trash screenshots and videos, but not downloads, or vice versa. We could extend trashAssetsBeforeRuns to accept boolean | { screenshots?: boolean, videos?: boolean, downloads?: boolean }.

But I guess that's probably not worth the effort, since the user can always add a plugin event to use fs to delete whatever they want between tests, and it's a rare use case.

We discussed this and decided we might change it later if users report issues with it not being broken up.

Is there an existing docs PR for this? It looks like trashAssetsBeforeRuns docs will need an update:

Yeah, it's part of cypress-io/cypress-documentation#3472. I'll add it to the PR description.

[flotwig]

Good to go once updated to use config.downloadsFolder

[flotwig]

looks great :)

[cypress-bot]

Released in 6.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.3.0, please open a new issue.