-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON fixtures format on test run #902
Labels
pkg/server
This is due to an issue in the packages/server directory
type: unexpected behavior
User expected result, but got another
Milestone
Comments
Duplicate : #884 |
I don't think so, #884 looks like it is specifically a windows issue with line endings |
Hmm reformatting your json fixture files or imported scripts does look like something cypress should not be doing
…Sent from my iPhone
On Nov 10, 2017, at 16:51, Graham McGregor ***@***.***> wrote:
I don't think so, #884 looks like it is specifically a windows issue with line endings
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I disagree that #884 is related to windows only, the issue is not about windows formatting, it is that cypress is rewriting the fixtures files instead of doing read-only. |
bahmutov
added
type: bug
type: unexpected behavior
User expected result, but got another
labels
Nov 16, 2017
jennifer-shehane
added
stage: ready for work
The issue is reproducible and in scope
and removed
type: bug
labels
Nov 16, 2017
bahmutov
added a commit
that referenced
this issue
Nov 16, 2017
bahmutov
added
pkg/server
This is due to an issue in the packages/server directory
stage: pending release
and removed
stage: ready for work
The issue is reproducible and in scope
labels
Nov 16, 2017
Released in |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg/server
This is due to an issue in the packages/server directory
type: unexpected behavior
User expected result, but got another
Is this a Feature or Bug?
Bug
Current behavior:
Whenever I run a test using a json fixture, the fixture file gets formatted. In my project I format all possible files using prettier. This includes json. The formatting that cypress applies conflicts with prettier. Specifically empty object blocks. (
{}
)Desired behavior:
Ideal: Format using prettier instead of whatever is used now.
Acceptable: Don't format fixtures.
How to reproduce:
Example:
https://prettier.io/playground/#N4Igxg9gdgLgprEAuEwA6UAEm3mgMwEsBzXJTdKDbAXwBocscR8IIzLttcAjAQwBOZTAEZqmGhhog6ICAAcYhaAGdkoPipjJ8fADYq4sngL5gA1nBgBleWcJRiyGAICuRkABMIYHfsOyAFYqAB4AQqYWVtZ8ALZwADIOcH4GHhCuMPKZAEypASB2AoYCyCDB0DKFAg4wAOqEnjAAFsgAHAAMsoaxhM5uHioOxHpwAIquEPD5HjB8PA1NrUg5si58hHrDAMIQsbF8ZVDQKbKuhgAq82pIumk0NEA
Test code:
See https://github.com/Graham42/cypress-bug-format-fixures
The text was updated successfully, but these errors were encountered: