Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing reporterOptions from the ResolvedConfigOptions in cypress #7877

Closed
admmasters opened this issue Jul 3, 2020 · 5 comments · Fixed by #8217
Closed

Missing reporterOptions from the ResolvedConfigOptions in cypress #7877

admmasters opened this issue Jul 3, 2020 · 5 comments · Fixed by #8217
Labels
type: typings Issue related to Cypress types (for TypeScript)

Comments

@admmasters
Copy link
Contributor

admmasters commented Jul 3, 2020 •
edited by sync-by-unito bot
Loading

Current behavior:

reporterOptions is missing from cypress.d.ts

Desired behavior:

reporterOptions should be added

Test code to reproduce

N/A these are typescript types

Versions

4.9.0
@jennifer-shehane jennifer-shehane added the type: typings Issue related to Cypress types (for TypeScript) label Jul 7, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jul 7, 2020
@jennifer-shehane
Copy link
Member

We're open to pull requests to add this!

@admmasters
Copy link
Contributor Author

Sure I’ll create a PR for this later 👍🏽

@admmasters admmasters mentioned this issue Aug 7, 2020
Merged
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Aug 7, 2020
@admmasters
Copy link
Contributor Author

Added #8217

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Aug 17, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 17, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 17, 2020

The code for this is done in cypress-io/cypress#8217, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add reporter options admmasters/cypress
2 participants
@admmasters @jennifer-shehane