Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReporterStats show more tests passing than cypress stats #7730

Closed
kuceb opened this issue Jun 16, 2020 · 3 comments · Fixed by #3968 · May be fixed by Omrisnyk/npm-lockfiles#145 or Omrisnyk/npm-lockfiles#164
Closed

ReporterStats show more tests passing than cypress stats #7730

kuceb opened this issue Jun 16, 2020 · 3 comments · Fixed by #3968 · May be fixed by Omrisnyk/npm-lockfiles#145 or Omrisnyk/npm-lockfiles#164
Assignees
@kuceb
Labels
type: breaking change Requires a new major release version type: unexpected behavior User expected result, but got another

Comments

@kuceb
Copy link
Contributor

kuceb commented Jun 16, 2020

  • due to how mocha emits events, if a test body passes, but the afterEach fails, reporterStats will mark 1 passed & 1 failed, whereas cypress will correctly report that 0 passed & 1 failed
  • we can fix this by buffering the mocha pass event and only emitting it to reporters after all hooks have run.

Current behavior:

Desired behavior:

Test code to reproduce

Versions
@kuceb kuceb mentioned this issue Jun 16, 2020
Merged
57 tasks
@jennifer-shehane
Copy link
Member

Would this effect people using mocha reporters as their sole output? Would this be a breaking change for them?

@jennifer-shehane jennifer-shehane added type: unexpected behavior User expected result, but got another type: breaking change Requires a new major release version labels Jun 17, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jul 14, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 10, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 10, 2020

The code for this is done in cypress-io/cypress#3968, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
type: breaking change Requires a new major release version type: unexpected behavior User expected result, but got another
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @kuceb