Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support just 'monthlyTests' and 'private' versus 'public' test recording copy from Test Runner errors #4024

Closed
jennifer-shehane opened this issue Apr 25, 2019 · 2 comments · Fixed by #4025
Closed

Support just 'monthlyTests' and 'private' versus 'public' test recording copy from Test Runner errors #4024

jennifer-shehane opened this issue Apr 25, 2019 · 2 comments · Fixed by #4025
Assignees
@jennifer-shehane
Labels
pkg/server This is due to an issue in the packages/server directory type: chore Work is required w/ no deliverable to end user

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Apr 25, 2019 •
edited
Loading

Current behavior:

Printed warning/errors upon over limit.

You've exceeded the limit of private test recordings under your free plan this month. The limit is 500 private test recordings.

To continue recording tests this month you must upgrade your account. Please visit your billing to upgrade to another billing plan.

Desired behavior:

The distinction of private versus public test recordings was removed recently from our pricing model. These words should be removed from warnings/errors in the Test Runner.

We are still supporting grandfathered in paid plans, which means we will need to handle new errors sent from the API: https://github.com/cypress-io/cypress-monorepo/issues/580

You've exceeded the limit of test recordings under your free plan this month. The limit is 500 test recordings.

To continue recording tests this month you must upgrade your account. Please visit your billing to upgrade to another billing plan.
@jennifer-shehane jennifer-shehane added pkg/server This is due to an issue in the packages/server directory stage: ready for work The issue is reproducible and in scope type: chore Work is required w/ no deliverable to end user difficulty: 1️⃣ labels Apr 25, 2019
@jennifer-shehane jennifer-shehane self-assigned this Apr 25, 2019
@jennifer-shehane jennifer-shehane changed the title Remove 'private' versus 'public' test recording copy from Test Runner errors Support just 'monthlyTests' and 'private' versus 'public' test recording copy from Test Runner errors Apr 25, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Apr 25, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Apr 25, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 17, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

The code for this is done in cypress-io/cypress#4025, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennifer-shehane jennifer-shehane

Labels
pkg/server This is due to an issue in the packages/server directory type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Test Runner to handle API errs for non-private test limits cypress-io/cypress
1 participant
@jennifer-shehane