Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement videoOnPasses config option #2890

Closed
kamituel opened this issue Dec 4, 2018 · 1 comment
Closed

Implement videoOnPasses config option #2890

kamituel opened this issue Dec 4, 2018 · 1 comment
Labels
topic: video 📹 type: duplicate This issue or pull request already exists

Comments

@kamituel
Copy link

kamituel commented Dec 4, 2018

Current behavior:

When video configuration option is set, Cypress will encode and save video regardless of whether any test in the run failed, or not. This increases the time required to complete the test run and wastes disk resources on CI agents.

Desired behavior:

A new setting option videoOnPasses, or a change to the existing video, that would make it possible to configure Cypress to encode and save a video recording of a test run only if there was a test failure.

This would be in a way equivalent to videoUploadOnPasses, but would prevent Cypress from even encoding a video file, not just from uploading it to the Dashboard.

This can be achieved partly by just checking the exit code of the Cypress' process, and deleting video artifacts the test run was successful, but then we'd still waste time encoding the video files.

Versions

3.1.3

@jennifer-shehane
Copy link
Member

Duplicate of #2522

@jennifer-shehane jennifer-shehane marked this as a duplicate of #2522 Dec 4, 2018
@jennifer-shehane jennifer-shehane added the type: duplicate This issue or pull request already exists label Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: video 📹 type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants