-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CT Stacktraces: Investigate Vite sourcemap mismatches #23919
Comments
Hey team! Please add your planning poker estimate with Zenhub @amehta265 @astone123 @lmiller1990 @marktnoonan @mike-plummer @rockindahizzy @warrensplayer @ZachJW34 |
The code for this is done in cypress-io/cypress#24063, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sourcemaps generated by Vite are often shifted by 1-3 columns, resulting in misaligned code frames (errors point to incorrect part of line that generated the error). This is worked around in current system tests by providing multiple column mappings to accept (see
reporter-ct-vite.errors.cy.ts
), and at runtime users will sometimes see codeframes that are incorrectly positioned.Need to investigate whether the sourcemaps themselves are incorrect, or whether we have logic in place that is breaking them due to Webpack-specific behaviors. This typically presents in JS-only files that are not transpiled by Vite (not JSX, TS, etc), so this may indicate an issue with the workaround we've added to
vite-dev-server
to always serve sourcemaps (seetransform
function ofcypress.ts
plugin undervite-dev-server
)The text was updated successfully, but these errors were encountered: