Videos getting generated for all the test cases whether pass or fail with "videoUploadOnPasses": false

[Sjain01]

Current behavior:

I am running bunch of test scenarios with option "videoUploadOnPasses": false and for all those scenarios whether pass or fail , video recordings are getting generated.

Desired behavior:

For example - in attached snapshot - forgot password has successfully executed but in next snapshot you can see the video is generated even though it has passed which in this case the video should not be generated

Steps to reproduce:

Set "videoUploadOnPasses": false and execute any test. Irrespective whether it fails or pass , video recordings are done by default for all.

Versions

Cypress: 3.1.0 │
Browser: Electron 59 (headless)

[bahmutov]

so the video is generated, but not uploaded to the Cypress dashboard. Do you think you want to just delete video file / not encode it on passing spec? Basically we have to record the video in case the spec fails...

[Sjain01]

@bahmutov - I can delete the video that is not an issue. But my issue here is as the cypress docs says setting "videoUploadOnPasses": false should only generate videos when the test case fails whereas in above case video is getting generated even if the test is passing.

[AlbertQM]

As mentioned by @bahmutov, videoUploadOnPasses != videoRecordOnPasses.

Although it'd be nice having Cypress deleting the video in case the spec passes.

In my case, I didn't need videos at all so I solved the problem by simply passing this flag.

config: {
        video:false
      }

[bahmutov]

@Sjain01 where do you see this in the docs, that seems wrong

https://docs.cypress.io/guides/references/configuration.html#Videos

[pmomot]

So now as I see, there is no option to have videos of only failing specs, is it correct?

[Sjain01]

@AlbertQM - Thank you for your suggestion but in my case I need videos only if the tests fails which I think is not possible to accomplish in current situation.

@bahmutov - please correct if I understood it wrong.

[bahmutov]

@pmomot yes, there is no option to only keep videos from failing tests
@Sjain01 I don't understand what is unclear about it - this talks about uploading to the dashboard, there is nothing about saving videos. How would you change the above description of videoUploadOnPasses?

[Sjain01]

@bahmutov - My bad, I mixed up two things , thank you for your time and explanation.

[seyfer]

I think this one can be closed in favor of #2522 ?