Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: Timed out after 4000ms. The done() callback was never invoked! #23203

Closed
rachelruderman opened this issue Aug 8, 2022 · 2 comments

Comments

@rachelruderman
Copy link
Contributor

rachelruderman commented Aug 8, 2022

Link to dashboard or CircleCI failure

https://dashboard.cypress.io/projects/ypt4pf/runs/37593/test-results/62729875-b095-464d-8987-72f2535fced6

Link to failing test in GitHub

https://github.com/cypress-io/cypress/blob/develop/packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts#L106

Analysis

We need to make sure done() is being called in the failure case. This won't fix the flake, but it will give us a more specific error message when this test flakes.

Cypress Version

10.4.0

Other

Search for this issue number in the codebase to find the test(s) skipped until this issue is fixed

@rachelruderman
Copy link
Contributor Author

Added .skip to this test in #23167. Please remove .skip when test is stable

@mschile mschile added triage and removed triage labels Aug 18, 2022
@flotwig
Copy link
Contributor

flotwig commented Nov 8, 2022

In 12.0.0 this test is invalidated by the removal of XHR monkey-patching in #24411, so I'm closing this since we won't do any work in this area between now and then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants