Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chrome) disabled Optimization Guide Prediction models #22622

Closed
emilyrohrbough opened this issue Jun 30, 2022 · 2 comments
Closed

(chrome) disabled Optimization Guide Prediction models #22622

emilyrohrbough opened this issue Jun 30, 2022 · 2 comments
Labels
browser: chrome browser: chromium type: enhancement Requested enhancement of existing feature

Comments

@emilyrohrbough
Copy link
Member

emilyrohrbough commented Jun 30, 2022

What would you like?

While debugging chrome crashes yesterday, I saw some interesting requests from Google...after a bit of googling, looks like Google runs Optimization Guide Prediction models when it is opened. This is the full list of optimization guide features.
We could (prob should?) disable these features by passing the following chrome argument on browser launch:

--disable-features=OptimizationGuideModelDownloading,OptimizationHintsFetching,OptimizationTargetPrediction,OptimizationHints

This might be one reason our windows resources suddenly tanked. There was a Chromium bug logged 20 days ago against Chrome 100 and a fix supposedly went out in 102, though someone mentioned they were on 102 and experience this issue as well.

With our Electron bump to 18.0.4 we bumped Chromium to 100.0.4896.75 and users have logged issues against electron performance issues. This might be related....

Need to confirm if it’s really downloading a 45mb file every time chrome launches and disable this if it is.

Other

Cypress 10.3.0

@cypress-bot cypress-bot bot added stage: routed to e2e-core and removed stage: needs investigating Someone from Cypress needs to look at this stage: routed to e2e-core labels Jun 30, 2022
@mjhenkes mjhenkes added stage: needs investigating Someone from Cypress needs to look at this E2E-core type: enhancement Requested enhancement of existing feature and removed stage: fire watch labels Jun 30, 2022
@mschile mschile added triage and removed triage labels Aug 18, 2022
@nagash77 nagash77 added E2E Issue related to end-to-end testing and removed E2E-core labels Nov 8, 2022
@jennifer-shehane
Copy link
Member

Found a couple of references on this:

I don't think I'd feel comfortable turning these off and the previous bug reported has been resolved. Puppeteer does not turn off these features.

@jennifer-shehane jennifer-shehane closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
@jennifer-shehane jennifer-shehane removed stage: needs investigating Someone from Cypress needs to look at this E2E Issue related to end-to-end testing labels Jan 24, 2024
@Siteload
Copy link

i dno what this is but i have this
found it in chrome://download-internals/

https://optimizationguide-pa.googleapis.com/downloads
/home/chronos/u-f662481de7e03628f27597be8e001eeb62f7ccf1/Download Service/Files/f1b7f3b0-d0c1-4d12-9077-0c81a3db94c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: chrome browser: chromium type: enhancement Requested enhancement of existing feature
Projects
None yet
Development

No branches or pull requests

6 participants