Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete comment about cookie secure context #21492

Closed
mjhenkes opened this issue May 13, 2022 · 4 comments
Closed

Remove obsolete comment about cookie secure context #21492

mjhenkes opened this issue May 13, 2022 · 4 comments
Assignees

Comments

@mjhenkes
Copy link
Member

See

if (this.experimentalSessionAndOrigin) {
// localhost is considered a secure context (even when http:)
// and it's required for cross origin support when visiting a secondary
// origin so that all its cookies are sent. This may be a
// breaking change, so put it behind the flag for now. Need to
// investigate further when we remove the experimental flag.
return !(cookie.secure && url.startsWith('http:') && !isLocalhost)
}

Is this a breaking change?

@AtofStryker
Copy link
Contributor

we might also need to add this in the simulated cookie handling in the server side jar here to be consistent

@mjhenkes
Copy link
Member Author

We don't think this is breaking so remove the condition and the comment.

@chrisbreiding chrisbreiding changed the title Look into if secure context cookie change is breaking Remove obsolete comment about cookie secure context Oct 25, 2022
@chrisbreiding
Copy link
Contributor

This was completed in #24340

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

Released in 12.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants