Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to onPointerDown #2045

Closed
ZakTax opened this issue Jun 27, 2018 · 4 comments · Fixed by #3030
Closed

Conversion to onPointerDown #2045

ZakTax opened this issue Jun 27, 2018 · 4 comments · Fixed by #3030
Assignees
Labels
type: feature New feature that does not currently exist

Comments

@ZakTax
Copy link

ZakTax commented Jun 27, 2018

Current behavior:

We are converting our app to React 16.4 which introduced Pointer Events API. However, items that we convert from onClick/onMouseDown-> onPointerDown break our Cypress tests. Everything works normally on our dev environment, and we have a PointerEvents polyfill as well (cypress' Chrome version supports the API natively).

Duplicating our onPointerDown={someAction} to onPointerDown={someAction} onMouseDown={someAction} fixes the tests but adds duplication.

Desired behavior:

Cypress should be able to handle onPointerDown events without code duplication

Versions

Cypress 3.0.1

@jennifer-shehane jennifer-shehane added type: feature New feature that does not currently exist stage: ready for work The issue is reproducible and in scope labels Jun 27, 2018
@jennifer-shehane
Copy link
Member

Pointer events documentation: https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events

Should be triggered on commands like:

  • .click()
  • .dblclick()
  • .check()
  • .uncheck()
  • .select()

You may be able to use .trigger() to trigger the pointerdown events in the meantime.

@kuceb kuceb self-assigned this Dec 17, 2018
@kuceb
Copy link
Contributor

kuceb commented Dec 17, 2018

@ZakTax Hi, we're planning on firing pointer events with cy.click as a part of Native Events #2956

@jennifer-shehane jennifer-shehane removed the stage: ready for work The issue is reproducible and in scope label Dec 19, 2018
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Aug 8, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 6, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Sep 25, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 7, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 11, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2019

The code for this is done in cypress-io/cypress#3030, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature New feature that does not currently exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants