Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio unable to save to files with special characters in path #14659

Closed
panzarino opened this issue Jan 20, 2021 · 3 comments · Fixed by #14679
Closed

Studio unable to save to files with special characters in path #14659

panzarino opened this issue Jan 20, 2021 · 3 comments · Fixed by #14679
Assignees
Labels
experiment: studio Issues when using experimentalStudio type: bug

Comments

@panzarino
Copy link
Contributor

panzarino commented Jan 20, 2021

Current behavior

Studio throws an error when trying to save to files that have a space somewhere in their path. If the space is removed, the saving works fine. I assume that a similar thing could be happening with open in ide since they share some of the same logic here but I'll have to test that.

Desired behavior

Studio should be able to save to all file names.

Test code to reproduce

See comment below

Originally reported by @ChaseBig #14339 (reply in thread)

@panzarino panzarino added type: bug experiment: studio Issues when using experimentalStudio labels Jan 20, 2021
@panzarino panzarino self-assigned this Jan 20, 2021
@jennifer-shehane
Copy link
Member

Specs with special characters also encounter this error - I know you'll get some people with Chinese/foreign characters with this error. Not sure about emoji 😅

And yes, the Open in IDE button in the reporter does not work for any of these files also

Screen Shot 2021-01-21 at 11 56 52 AM

Shows error:

Cypress was unable to save these commands to your spec file. Cypress Studio is still in beta and the team is working hard to resolve issues like this. To help us fix this issue more quickly, you can provide us with more information by clicking 'Learn more' below

Screen Shot 2021-01-21 at 11 55 03 AM

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jan 21, 2021
@panzarino panzarino changed the title Studio unable to save to files with spaces in path Studio unable to save to files with special characters in path Jan 21, 2021
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jan 21, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jan 22, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 22, 2021

The code for this is done in cypress-io/cypress#14679, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
experiment: studio Issues when using experimentalStudio type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants