Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contains(0) does not show zero in the command log #1119

Closed
bahmutov opened this issue Dec 21, 2017 · 5 comments · Fixed by #16998 · May be fixed by FuhuXia/inventory-app#3
Closed

contains(0) does not show zero in the command log #1119

bahmutov opened this issue Dec 21, 2017 · 5 comments · Fixed by #16998 · May be fixed by FuhuXia/inventory-app#3
Assignees
Labels
good first issue Good for newcomers pkg/reporter This is due to an issue in the packages/reporter directory type: bug type: user experience Improvements needed for UX

Comments

@bahmutov
Copy link
Contributor

small bug in Cypress 1.4.0

Repo with reproducible test https://github.com/bahmutov/test-cy-contains-zero

The following test

it('contains string zero', () => {
  cy.visit('index.html')
  cy.get('#zero').contains('0')
})

it('contains number zero', () => {
  cy.visit('index.html')
  cy.get('#zero').contains(0)
})

Shows "0" in the first test, but shows nothing in the second test.

contains-zero

Should show "CONTAINS 0" in the second test

@bahmutov bahmutov added pkg/reporter This is due to an issue in the packages/reporter directory severity: minor type: bug type: user experience Improvements needed for UX labels Dec 21, 2017
@jennifer-shehane
Copy link
Member

I had opened this a long time ago. It appears it is still in our private repo and was never opened when we went open source. Going to check over to see if there are any other leftover issues left private. https://github.com/cypress-io/cypress-monorepo/issues/334

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jul 11, 2019
@jennifer-shehane jennifer-shehane added good first issue Good for newcomers and removed stage: ready for work The issue is reproducible and in scope labels Jul 11, 2019
@jennifer-shehane
Copy link
Member

This issue is still happening in 3.4.0

@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Jan 5, 2021
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jun 17, 2021
@dario-piotrowicz
Copy link
Contributor

@jennifer-shehane as of 7.5.0 the issue is still happening so I created a PR to fix it

I just noticed you were assigned to this issue, I hope you don't mind me opening the PR for it 😢
(it didn't look like you were actively looking into it anyhow)

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jun 28, 2021
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 6, 2021
@jennifer-shehane
Copy link
Member

The code for this is done, but this has yet to be released. We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2021

Released in 7.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers pkg/reporter This is due to an issue in the packages/reporter directory type: bug type: user experience Improvements needed for UX
Projects
None yet
3 participants