Be less aggressive with error messages when plugins cause errors

[Graham42]

In this bug: cypress-io/cypress-watch-preprocessor#1

The wording of the error message that the user experiences has a fairly aggressive tone. Specifically this line:

This error originated from *your* test code, not from Cypress.

The error message could be better phrased to something like "This is an error from your test code."

When building developer tools it's very important to keep DX (developer experience) in mind.

[brian-mann]

We derive most of our errors messages out the the feedback we get and the questions we get from real users.

These error messages just went in 1.1.3 and they originated from many situations where users thought that Cypress was throwing the error (assuming there was a bug in it). Other users were also confused whether the error was coming from test code or application code.

We updated these errors to clearly call out the point of origin, and a suggestion that the user must take action to fix it. Here's the issue that documents these errors:

#825

If you search in our issues or search gitter you will find that users regularly were confused without this specific wording. They'd have to inspect a stack trace, and even before doing that, they might not recognize the error and have no idea where it's coming from or why. Many times they would ask: "Is there a bug in Cypress?" We wanted to make it super clear that this is something on their end, and this error is happening as part of the test framework as opposed to a software error in Cypress itself.

I'll keep this issue open if anyone else has an opinion. You can find the errors and rewrite them and submit a PR if you'd like.

[jennifer-shehane]

I think they are just suggesting changing a couple words in the error. 🙃

I agree, the use of the phrase 'an error from' is much clearer than 'error originated from'.

Code where these messages can be found:

• https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cypress/error_messages.coffee#L792
• https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cypress/error_messages.coffee#L802

There are several tests and snapshots that will require updating when changing this message.

[Graham42]

That reasoning makes sense. I've submitted a PR for a minimal change which I think tweaks the tone of this error message. Let me know what you think.

#1038

[brian-mann]

Released in 1.2.0.