From d6764487e14ca19a8186cba135c029fbaf043854 Mon Sep 17 00:00:00 2001 From: Mike Plummer Date: Tue, 16 Aug 2022 16:30:46 +0000 Subject: [PATCH] fix: Display full spec file extension in popovers (#23350) Co-authored-by: Emily Rohrbough --- packages/app/cypress/e2e/specs_list_flaky.cy.ts | 2 +- packages/app/src/specs/SpecsList.vue | 2 +- packages/app/src/specs/flaky-badge/FlakyInformation.cy.tsx | 2 +- packages/app/src/specs/flaky-badge/FlakyInformation.vue | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/app/cypress/e2e/specs_list_flaky.cy.ts b/packages/app/cypress/e2e/specs_list_flaky.cy.ts index 33361953e33e..4619f374912e 100644 --- a/packages/app/cypress/e2e/specs_list_flaky.cy.ts +++ b/packages/app/cypress/e2e/specs_list_flaky.cy.ts @@ -94,7 +94,7 @@ describe('App: Spec List - Flaky Indicator', () => { cy.contains('[data-cy="spec-item"]', '123.spec.js').find('.v-popper').trigger('mouseenter') cy.findByTestId('flaky-spec-summary').within(() => { - cy.contains('123.js') + cy.contains('123.spec.js') cy.contains('Low') cy.contains('4% flaky rate') cy.contains('2 flaky runs / 50 total') diff --git a/packages/app/src/specs/SpecsList.vue b/packages/app/src/specs/SpecsList.vue index 78587d0b07b9..d068a0613d5c 100644 --- a/packages/app/src/specs/SpecsList.vue +++ b/packages/app/src/specs/SpecsList.vue @@ -130,7 +130,7 @@
', () => { __typename: 'Spec', id: '2', fileName: 'abc', - fileExtension: 'cy.tsx', + specFileExtension: 'cy.tsx', relative: 'test/abc.cy.tsx', } const cloudSpec: FlakyInformationCloudSpecFragment = { diff --git a/packages/app/src/specs/flaky-badge/FlakyInformation.vue b/packages/app/src/specs/flaky-badge/FlakyInformation.vue index 570511d91b50..453bfc2e492b 100644 --- a/packages/app/src/specs/flaky-badge/FlakyInformation.vue +++ b/packages/app/src/specs/flaky-badge/FlakyInformation.vue @@ -25,7 +25,7 @@ :from-branch="props.projectGql?.branch || ''" :spec-path="props.specGql.relative" :spec-name="props.specGql?.fileName ?? ''" - :spec-extension="props.specGql?.fileExtension ?? ''" + :spec-extension="props.specGql?.specFileExtension ?? ''" /> @@ -56,7 +56,7 @@ fragment FlakyInformationSpec on Spec { id relative fileName - fileExtension + specFileExtension } `