Mui5 #1550
Closed
Mui5 #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add @mui/icons-material
First, the color changes indicated at https://mui.com/material-ui/migration/v5-component-changes/#update-default-indicatorcolor-and-textcolor-prop-values Second, remove the the trailing "px" a number rather than string when passing values to the react-virtualized List component. See https://mui.com/material-ui/migration/v5-style-changes/\#%E2%9C%85-remove-px-suffix
this was causing the slider-based cypress tests to fail.
appBar was still over the date picker in mobile screen size, failing one of the cypress:run:mobile tests. See also https://mui.com/material-ui/migration/v5-component-changes/\#fix-z-index-issues
followed by lint fixes and manual review
…nkAccountForm.tsx linting and review
…mmentForm.tsx review, lint
…inLayout.tsx review, remove class for root and use ampersand instead, adding a flexGrow:1 to get styling as before
…vBar.tsx, review, appBarShift was incorrectly considered a child of root; fixed that with removal of space between & and ., lint
…vDrawer.tsx review, lint, no issues
…tificationListItem.tsx review, lint, no issues
…gnInForm.tsx lint, cast StyledContainer to typeof Container per https://github.com/mui/material-ui/issues/15695\#ref-commit-7fd1a29
…gnUpForm.tsx lint, cast StyledContainer to typeof Container per https://github.com/mui/material-ui/issues/15695\#ref-commit-7fd1a29
…eletonList.tsx lint, review, no issues
…ansactionAmount.tsx lint, remove space between & and . because classes are conditionally applied
…ansactionCreateStepOne.tsx lint and review, no issues
…ansactionCreateStepTwo.tsx lint, review, no issues
…ansactionCreateStepThree.tsx lint, review, no issues
…ansactionDateRangeFilter.tsx lint, review, no issues
…ansactionDetail.tsx lint, review, no issues
…ansactionItem.tsx lint, review, problems with SmallAvatar, fixed manually
…ansactionList.tsx lint, review, no issues
…ansactionListAmountRangeFilter.tsx lint, review, did not work really at all, fixed by using sx prop rather than classes at all
…ansactionListFilters.tsx lint, review, no issues
…ansactionTitle.tsx lint, review, no issues
…erSettingsForm.tsx lint, review, form did not want to play nice with classes, fixed with sx for submit button and styled wrapping div for form
had apparently accidentally failed-to-checkin TransactionInfiniteList and userSearchForm, but both were reviewed and had no issues
minor style fixups to be rid of the dependency causing the peer dependency warning
…lock merge resolution
which is not failing after the upgrade to MUI v5. See #1278
cypress-realworld-app
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-realworld-app
|
| Branch Review |
mui5
|
| Run status |
|
| Run duration | 09m 15s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
98.08%
|
|
|---|---|
|
Untested elements
|
1
|
|
Tested elements
|
41
|
Accessibility
72.41%
|
|
|---|---|
|
Failed rules
|
0 critical
3 serious
0 moderate
0 minor
|
|
Failed elements
|
16
|
AvatarGroup in mui5.
no longer overlapping. Instead eat up space to right of avatars.
modifying input styles
|
|
closing in favor of #1522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run as draft to run percy to see visual diff. will ultimately close in favor of #1522