Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscriptions #81

Closed
wants to merge 3 commits into from
Closed

Add subscriptions #81

wants to merge 3 commits into from

Conversation

kinow
Copy link
Member

@kinow kinow commented Sep 26, 2019

Closes #14

  • Will use a file that is still under review, but we have tested and it works for what we need (and looks like the code review will take much longer in graphql-ws)
  • Will use the simplest approach available, of just looping and asyncio.sleeping for a few seconds, then sending more data. This can be improved later to send data only when there is data available, but this will be an improvement for later.

@kinow kinow added this to the 0.2 milestone Sep 26, 2019
@kinow kinow self-assigned this Sep 26, 2019
@kinow kinow closed this Sep 26, 2019
@kinow kinow removed this from the 0.2 milestone Sep 26, 2019
@matthewrmshin matthewrmshin added wontfix This will not be worked on duplicate This issue or pull request already exists and removed wontfix This will not be worked on labels Sep 26, 2019
@matthewrmshin
Copy link
Contributor

Moved to #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsutherland dwsutherland Awaiting requested review from dwsutherland

Assignees

@kinow kinow

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GraphQL subscriptions support via WebSocket
2 participants
@kinow @matthewrmshin