-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible silent failure to connect to workflow #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure about testing this one |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 76.96% 77.05% +0.08%
==========================================
Files 12 12
Lines 1385 1412 +27
Branches 236 239 +3
==========================================
+ Hits 1066 1088 +22
- Misses 276 277 +1
- Partials 43 47 +4
☔ View full report in Codecov by Sentry. |
MetRonnie
force-pushed
the
workflow-mgr-bug
branch
from
July 6, 2023 14:07
9103400
to
ec3f47e
Compare
MetRonnie
commented
Jul 6, 2023
wxtim
reviewed
Jul 6, 2023
oliver-sanders
approved these changes
Jul 10, 2023
wxtim
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you played a workflow with the same workflow ID as a previously existing one, but a new UUID, the UI Server was not connecting to it.
Due to cylc/cylc-flow#5615 this was affecting restarting any workflow.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.