Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible silent failure to connect to workflow #463

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jul 4, 2023

If you played a workflow with the same workflow ID as a previously existing one, but a new UUID, the UI Server was not connecting to it.

Due to cylc/cylc-flow#5615 this was affecting restarting any workflow.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added the bug Something isn't working label Jul 4, 2023
@MetRonnie MetRonnie added this to the 1.3.0 milestone Jul 4, 2023
@MetRonnie MetRonnie marked this pull request as ready for review July 6, 2023 14:04
@MetRonnie
Copy link
Member Author

Not sure about testing this one

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Patch coverage: 68.75% and project coverage change: +0.08 🎉

Comparison is base (929714a) 76.96% compared to head (ec3f47e) 77.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   76.96%   77.05%   +0.08%     
==========================================
  Files          12       12              
  Lines        1385     1412      +27     
  Branches      236      239       +3     
==========================================
+ Hits         1066     1088      +22     
- Misses        276      277       +1     
- Partials       43       47       +4     
Impacted Files Coverage Δ
cylc/uiserver/workflows_mgr.py 83.23% <68.75%> (-0.89%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGES.md Show resolved Hide resolved
@MetRonnie MetRonnie self-assigned this Jul 7, 2023
@wxtim wxtim merged commit 1805700 into cylc:master Jul 10, 2023
@MetRonnie MetRonnie deleted the workflow-mgr-bug branch July 10, 2023 15:14
@MetRonnie MetRonnie linked an issue Jul 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes, a running workflow displays as stopped
4 participants