Clean gui info files #431
Merged
Clean gui info files #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamel
commented
Mar 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 78.78% 78.98% +0.20%
==========================================
Files 12 12
Lines 1296 1318 +22
Branches 218 221 +3
==========================================
+ Hits 1021 1041 +20
- Misses 231 233 +2
Partials 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
wxtim
reviewed
Mar 13, 2023
wxtim
reviewed
Mar 13, 2023
wxtim
reviewed
Mar 13, 2023
wxtim
approved these changes
Mar 16, 2023
MetRonnie
reviewed
Mar 30, 2023
| def get_url_from_file(gui_file): | ||
| with open(gui_file, "r") as f: | ||
| file_content = f.read() | ||
| url_extract_regex = re.compile('url=(.*?)\"') |
There was a problem hiding this comment.
😈 https://stackoverflow.com/a/1732454/3217306
May be better to use https://docs.python.org/3/library/html.parser.html in future?
There was a problem hiding this comment.
🤣
(probably OK in this context)
There was a problem hiding this comment.
Yeah probably only worth doing in future if it breaks at some point
Co-authored-by: Ronnie Dutta <[email protected]>
MetRonnie
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #416
This fixes a bug whereby, if an existing ui-server is killed with a
kill -9or with a system crash, jupyter server info files (which serve as a contact file) can be left behind. This is problematic as our logic (added in #370) can select the broken server for re-use which results in the gui opening at an error page, rather than the cylc gui.How to test
For reviewers to test (on master to reproduce the bug)...
cylc guicylc gui(don't use the--newoption)Test again on this branch and the bug should be fixed, with a prompt asking you if you wish to remove the files (either response should result in a gui being opened correctly)
Note that this branch also changes the logic - the html open file is now no longer written to in this process, so functional testing of various gui openings (e.g. with/without
--newandworkflow_id) would be prudent.CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users