-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable USER_CONF_ROOT path #489
Comments
Sounds reasonable. |
Note, the logging that Jupyter Server / Cylc UI Server uses is already configurable. Here's the default configuration: cylc-uiserver/cylc/uiserver/jupyter_config.py Lines 67 to 96 in de7580a
E.G. swap out the filename for something like |
Unix file permissions are read/write/execute so I think append-only permissions could only be implemented at the filesystem level using something funky. Note that Cylc is currently configured to open the log file using Python's append mode:
|
Note, you can do some advanced things like https://docs.python.org/3/howto/logging-cookbook.html#customizing-handlers-with-dictconfig |
Problem
The
USER_CONF_ROOT
path is used in a variety of places for storing logs, secrets and the Jupyter database. While most uses are configurable injupyter_config.py
, the output path ofRotatingUISFileHandler
is not. We'd like to place this log in a different location with append-only permissions.Proposed Solution
USER_CONF_ROOT
to be configured with an environment variable, e.g.$CYLC_CONF_PATH
in the same way as cylc-flow.and/or
c.CylcUIServer.server_log_path
that sets an output path forRotatingUISFileHandler
(defaulting toUSER_CONF_ROOT/log
as it currently does).I can see a complication that
RotatingUISFileHandler
is initialised very early in the startup, potentially before the configuration is loaded.The text was updated successfully, but these errors were encountered: