You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe exactly what you would like to see in an upcoming release
I had it in my notes from a long time ago, when I first started chopping parts of the JupyterHub single-user application, to get our UI Server working.
One thing that I completely ignored at that time was the whole Traitlets code.
Not sure if we need that. In theory the application spawned by the JupyterHub spawners doesn't need to use traitlets, but I never looked if there are any advantages of using it (hence the "question" label).
The only advantages of using it, I think, would be a) being able to use Python in the jupyterhub_config.py to define variables that could be shared/used in different sections of the file, e.g.
and b) using the same tooling as the default application launched by the Hub spawners (i.e. notebook).
But there are probably cons too, like another dependency to the project, we wouldn't have our own configuration file, maybe we want to have more control on how configuration is done, etc.
No strong opinion on this, just remembered about this because yesterday I was reading the JupyterHub code while writing some cookie documentation.
Additional context
Here's one example from Jupyter Core. This is the base class of the NotebookApp, which is used by JupyterHub by default with the spawners, and we have replaced with our UI Server.
It provides the application configuration. The jupyterhub_config.py leverages of traitlets to load properties. That's how we have c.JupyterHub.properties, c.ConfigProxy.properties, and c.BatchSpawner.properties, etc.
Traitlets supports things such as defining an object property that will be initialized from the configuration file, with a default value, but that can be overridden by an environment variable.
Pull requests welcome!
The text was updated successfully, but these errors were encountered:
Describe exactly what you would like to see in an upcoming release
I had it in my notes from a long time ago, when I first started chopping parts of the JupyterHub single-user application, to get our UI Server working.
One thing that I completely ignored at that time was the whole Traitlets code.
Not sure if we need that. In theory the application spawned by the JupyterHub spawners doesn't need to use traitlets, but I never looked if there are any advantages of using it (hence the "question" label).
The only advantages of using it, I think, would be a) being able to use Python in the
jupyterhub_config.py
to define variables that could be shared/used in different sections of the file, e.g.and b) using the same tooling as the default application launched by the Hub spawners (i.e. notebook).
But there are probably cons too, like another dependency to the project, we wouldn't have our own configuration file, maybe we want to have more control on how configuration is done, etc.
No strong opinion on this, just remembered about this because yesterday I was reading the JupyterHub code while writing some cookie documentation.
Additional context
Here's one example from Jupyter Core. This is the base class of the
NotebookApp
, which is used by JupyterHub by default with the spawners, and we have replaced with our UI Server.It provides the application configuration. The
jupyterhub_config.py
leverages of traitlets to load properties. That's how we havec.JupyterHub.properties
,c.ConfigProxy.properties
, andc.BatchSpawner.properties
, etc.Traitlets supports things such as defining an object property that will be initialized from the configuration file, with a default value, but that can be overridden by an environment variable.
Pull requests welcome!
The text was updated successfully, but these errors were encountered: