Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylc Hub configuration #111

Closed
1 of 2 tasks
oliver-sanders opened this issue Jan 22, 2020 · 3 comments
Closed
1 of 2 tasks

Cylc Hub configuration #111

oliver-sanders opened this issue Jan 22, 2020 · 3 comments
Labels
question Flag this as a question for the next Cylc project meeting.

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 22, 2020

At the moment we have the jupyterhub configuration defined in a single python file within the repo.

We intend to have all Cylc configuration files contained within the same tree for ease of management (cylc/cylc-flow#3170) something along the lines of this:

  • <configuration_root_dir>/
    • flow/
      • 8.0.0/
        • flow.rc
      • 8.0.1/
        • flow.rc
    • hub/ (or ui-server?)
      • 1.0.0/
        • ui_server.py

How do we want to move forward with the configuration options:

  • Do nothing:
    • Give users a template jupyterhub config file.
    • leave it up to them to put this file somewhere sensible.
    • Leave it up to them to specify the path to their own jupyterhub config file.
  • Create a cylc hub command which:
    • Is a thin wrapper to jupyterhub which sets the config path:
      • Adds the jupytefhub_config.py file from this repo (which sets the logo etc).
      • Adds user/site config from the Cylc configuration tree.

Pull requests welcome!

@oliver-sanders oliver-sanders added the question Flag this as a question for the next Cylc project meeting. label Jan 22, 2020
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Dec 23, 2020

Suggest creating a quick simple cylc hub command that wraps Jupyterhub:

  • Easy to do with the cylc.command entry point.
  • Should ensure jupyterhub runs with the Cylc configuration.
  • Puts jupyterhub behind a cylc command (will appear to ps as such) which allows command whitelisting.
  • Should also load the user config ~/.cylc/ui-server/[<version>/]jupyterhub_config.py (after the base Cylc config).
  • This will bring the jupyterhub and uiserver configs into the same location, etc.
  • Should still work when launched manually (providing you specify the base config file or are in the cylc-uiserver directory), you just loose the user config file stuff.
  • Add a support for a site config later.

@oliver-sanders
Copy link
Member Author

Added a cylc hub command in #173 along with a user config.

We now have the ability to define the configuration hierarchy how we want it, leaving this open as a question until we discuss & agree how we would like this to work.

This was referenced Mar 22, 2021
@oliver-sanders
Copy link
Member Author

superseded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Flag this as a question for the next Cylc project meeting.
Projects
None yet
Development

No branches or pull requests

1 participant