Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit and/or e2e tests for GScan sort #553

Closed
kinow opened this issue Dec 8, 2020 · 1 comment · Fixed by #571
Closed

Add more unit and/or e2e tests for GScan sort #553

kinow opened this issue Dec 8, 2020 · 1 comment · Fixed by #571
Assignees
@kinow
Milestone
0.3.0

Comments

@kinow
Copy link
Member

kinow commented Dec 8, 2020

Describe exactly what you would like to see in an upcoming release

In #537 there is a change to sorting that doesn't seem to trigger any tests. It shows that we probably need a few more tests to verify the order of the workflows is working as expected.

Additional context

Pull requests welcome!
@kinow kinow added this to the 0.3 milestone Dec 8, 2020
@kinow kinow self-assigned this Dec 8, 2020
@kinow
Copy link
Member Author

kinow commented Jan 14, 2021 •
edited
Loading

Triaging 0.3 issues. This looks like a good one for Friday afternoon while the existing PR's are reviewed. Will read the code today to see what tests are missing, and start planning how to write the tests (update existing tests, add new ones, unit or e2e, etc).

@kinow kinow mentioned this issue Jan 15, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinow kinow

Labels
None yet
Projects
None yet
Milestone
0.3.0
1 participant
@kinow