Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rose stem installs to ~/cylc-run/rose-stem #177

Closed
wxtim opened this issue Sep 7, 2022 · 1 comment · Fixed by #180
Closed

Rose stem installs to ~/cylc-run/rose-stem #177

wxtim opened this issue Sep 7, 2022 · 1 comment · Fixed by #180
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented Sep 7, 2022

Describe the bug

When $PWD is not a subversion repo rose stem --source=X=$PWD is unable to get a name for the workflow install directory and installs the workflow in ~/cylc-run/rose-stem. Ideally the basename of the source directory should be used.

Expected behavior

rose stem --source=X=/home/h02/tpilling/cylc-src/example
...
- INSTALLED example/run1 from /net/home/h02/tpilling/cylc-src/example/rose-stem
+ INSTALLED rose-stem/run3 from /net/home/h02/tpilling/cylc-src/example/rose-stem

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@wxtim wxtim added the bug Something isn't working label Sep 7, 2022
@wxtim wxtim self-assigned this Sep 7, 2022
@wxtim wxtim mentioned this issue Sep 7, 2022
7 tasks
@wxtim
Copy link
Member Author

wxtim commented Sep 9, 2022

At Cylc 8 this is a potentially problematic bug for some users, because they won't be able to reinstall with

WorkflowFilesError: Failed to install from /path/tims-rose-stem/rose-stem: previous installations were from /path/bb/rose-stem

@wxtim wxtim modified the milestones: 1.1.1, 1.1.2 Sep 13, 2022
@wxtim wxtim linked a pull request Sep 13, 2022 that will close this issue
7 tasks
@wxtim wxtim modified the milestones: 1.1.2, 1.1.1 Sep 13, 2022
@wxtim wxtim added enhancement New feature or request and removed bug Something isn't working labels Sep 14, 2022
@wxtim wxtim modified the milestones: 1.1.1, 1.2.0, 1.1.2 Sep 14, 2022
@wxtim wxtim closed this as completed Nov 1, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.1.2, 1.2.0 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants