Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of WorkflowRuntimeServer.get_graph_raw() #4523

Closed
MetRonnie opened this issue Nov 18, 2021 · 3 comments · Fixed by #4683
Closed

Future of WorkflowRuntimeServer.get_graph_raw() #4523

MetRonnie opened this issue Nov 18, 2021 · 3 comments · Fixed by #4683
Assignees
Milestone

Comments

@MetRonnie
Copy link
Member

Is this endpoint no longer used, and can it be removed?

@authorise()
@expose
def get_graph_raw(
self, start_point_str, stop_point_str, grouping=None
):
"""Return a textual representation of the workflow graph.

And what about WorkflowRuntimeServer.api()?

@authorise()
@expose
def api(self, endpoint=None):
"""Return information about this API.
Returns a list of callable endpoints.

@MetRonnie MetRonnie added the question Flag this as a question for the next Cylc project meeting. label Nov 18, 2021
@MetRonnie MetRonnie added this to the cylc-8.0rc1 milestone Nov 18, 2021
@MetRonnie MetRonnie changed the title Future of WorkflowRuntimeServer.get_graph_raw()` Future of WorkflowRuntimeServer.get_graph_raw() Nov 18, 2021
@oliver-sanders
Copy link
Member

This could be useful for static graph visualisation, however, we should provide that endpoint from the UIS.

So long as it isn't currently used by cylc-flow/cylc-uiserver (which it shouldn't be, then it's good for removal)

@wxtim
Copy link
Member

wxtim commented Nov 24, 2021

This could be useful for static graph visualisation, however, we should provide that endpoint from the UIS.

So long as it isn't currently used by cylc-flow/cylc-uiserver (which it shouldn't be, then it's good for removal)

@oliver-sanders - Is your answer definitive enough to remove the question tag?

@oliver-sanders
Copy link
Member

Unused but also harmless. Low priority.

@oliver-sanders oliver-sanders removed the question Flag this as a question for the next Cylc project meeting. label Nov 24, 2021
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0rc1, cylc-8.x Nov 24, 2021
@MetRonnie MetRonnie mentioned this issue Feb 11, 2022
7 tasks
@MetRonnie MetRonnie modified the milestones: cylc-8.x, cylc-8.0rc1 Feb 15, 2022
@MetRonnie MetRonnie self-assigned this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants