Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved control command interface. #423

Closed
hjoliver opened this issue Apr 12, 2013 · 3 comments
Closed

Improved control command interface. #423

hjoliver opened this issue Apr 12, 2013 · 3 comments
Labels
duplicate This is a duplicate of something else

Comments

@hjoliver
Copy link
Member

hjoliver commented Apr 12, 2013

Control commands return immediately after queuing a command request to the suite. If the command is successful the user will see the expected result via suite monitoring, but if not (e.g. a supplied task ID regex does not match in tasks in the suite) the suite log must be examined to see what happened.

One idea I've had is to generate a unique ID at the time the request is queued, report it back to the user ("command ade3af99 queued" instead of just "command queued") and then have the suite log the result against the ID. This would allow a --wait option to make the command script wait until the result shows up, and report it, before exiting. Would have to allow for possible log rollover during the wait time (or else use the run-db instead of the log.

@hjoliver
Copy link
Member Author

hjoliver commented Jun 19, 2016

[meeting] we agreed:

  • the command ID would work, possibly with a new command to retrieve the result of a command (given the ID), plus --wait options for all commands.
  • some commands should report failure back immediately, e.g. if a task-matching regex does not match any tasks to operate on.
  • we should also consider:
    • task-matching regex commands to ask if the matched list of tasks is as intended
    • if a target task is not in the pool, ask if the user wants to insert it
    • auto-insertion (at least with --force), e.g. to retrigger tasks that have been removed from the pool

@hjoliver hjoliver changed the title Reporting control command results to users. Improved control command interface. Jun 19, 2016
@matthewrmshin
Copy link
Contributor

In the proposed new web architecture, we should be able to make use of asynchronous 2-way communication to achieve the feedback functionality.

@oliver-sanders
Copy link
Member

oliver-sanders commented Jun 9, 2020

Merging this with #3329 which proposes pretty much the same thing as proposed here only utilising PUB/SUB to update the client with the command's progress when running interactively.

@oliver-sanders oliver-sanders removed this from the cylc-8.0.0 milestone Jul 15, 2020
@oliver-sanders oliver-sanders added the duplicate This is a duplicate of something else label Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This is a duplicate of something else
Projects
None yet
Development

No branches or pull requests

3 participants