Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: date strings should be parsed with system time zone considered #365

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix: date strings should be parsed with system time zone considered #365

merged 1 commit into from
Nov 4, 2022

Conversation

cyjake
Copy link
Owner

@cyjake cyjake commented Nov 3, 2022 

Post.where('createdAt > ?', '2022-11-03')

should generate following SQL

-- correct
SELECT * FROM articles WHERE gmt_create > '2022-11-03 00:00:00.000'

rather than

-- wrong
SELECT * FROM articles WHERE gmt_create > '2022-11-02 16:00:00.000'

@cyjake cyjake force-pushed the fix-date-parsing-with-timezone branch from 982f5f9 to c7307ee Compare November 3, 2022 11:41
@JimmyDaddy JimmyDaddy merged commit 18b6c5d into master Nov 4, 2022
@JimmyDaddy JimmyDaddy deleted the fix-date-parsing-with-timezone branch November 4, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyDaddy JimmyDaddy JimmyDaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyjake @JimmyDaddy