fix: generic type for getDataValue #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
reviewed
Sep 21, 2022
cyjake
reviewed
Sep 21, 2022
| setDataValue(key: string, value: Literal | Literal[]): void; | ||
| getDataValue(key?: string): Literal | { [key: string]: Literal }; | ||
| setDataValue<T, Key extends keyof T>(this: T, key: Key, value: T[Key]): void; | ||
| getDataValue<T>(this: T): T; |
There was a problem hiding this comment.
啊？这样不对吧？
是不是没办法 getDataValue<T>(this: T, key: string): T[key] 这样
There was a problem hiding this comment.
overload 没问题啊，本身不传值返回的就是 this，传值就是 this[key] 👇
There was a problem hiding this comment.
看懂啦，会不会有点太麻烦了😂
你们模型层切换到 ts 了没，已经切换的话，this.getDataValue<User['id']> 可以用 this.id 平替呀
cyjake
reviewed
Sep 21, 2022
vagusX
commented
Sep 21, 2022
cyjake
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.