Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instance beforeUpdate hooks should not modify any Raw if there are no Raw assignment in them #283

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

JimmyDaddy
Copy link
Collaborator

att

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #283 (73bb8fb) into master (0c5e6bc) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   97.51%   97.55%   +0.04%     
==========================================
  Files          44       44              
  Lines        3222     3236      +14     
==========================================
+ Hits         3142     3157      +15     
+ Misses         80       79       -1     
Impacted Files Coverage Δ
src/bone.js 98.16% <100.00%> (+0.17%) ⬆️
src/setup_hooks.js 98.88% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5e6bc...73bb8fb. Read the comment docs.

@cyjake cyjake merged commit 582d9bf into master Feb 28, 2022
@cyjake cyjake deleted the fix/instance_before_update_hooks_logic branch February 28, 2022 11:38
cyjake pushed a commit that referenced this pull request Feb 28, 2022
…s no Raw assignment in them (#283)

Co-authored-by: JimmyDaddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants