fix: fix #260 UPDATE with LIMIT and ORDER should be formatted(mysql only) #261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 97.32% 97.33%
=======================================
Files 44 44
Lines 3144 3155 +11
=======================================
+ Hits 3060 3071 +11
Misses 84 84
Continue to review full report at Codecov.
|
| const extraOptions = this.formatUpdateExtraOptions(spell); | ||
| if (extraOptions.length) { | ||
| chunks.push(...extraOptions); | ||
| } |
There was a problem hiding this comment.
This bug fix shouldn't be sequelize adapter specific I think. Use cases like below should be supported as well:
Post.update({ title: null }, { title: 'Untitled' }).order('id', 'desc').limit(10);There was a problem hiding this comment.
This bug fix shouldn't be sequelize adapter specific I think. Use cases like below should be supported as well:
Post.update({ title: null }, { title: 'Untitled' }).order('id', 'desc').limit(10);
It's a MySQL only feature, this was supported at this PR, see
test/integration/suite/basics.test.js:685
test/unit/spell.test.js:638
| @@ -682,6 +682,21 @@ describe('=> Basic', () => { | |||
| expect(posts.length).to.equal(affectedRows); | |||
| }); | |||
|
|
|||
| it('Bone.update(where, values) should work with limit/offset and order', async function() { | |||
| if (Post.driver.type === 'mysql') { | |||
attr