Merge 1.x changes #249
Merged
Merge 1.x changes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: information_schema.columns.datetime_precision `new Model(values)` should have values rounded according to precision * fix: date rounding
#247) ```js const result = await Post.include('comments').order('comments.id', 'desc').order('posts.id', 'desc').limit(1); ``` This query might retrives wrong result because the post with latest comments isn't necessarily the latest one, such as: | post_id | comment_id | |---------|------------| | 1 | 3 | | 2 | 2 | | 3 | 1 | Previous implementation will yield SQL like: ```sql SELECT posts.*, comments.* FROM (SELECT * FROM posts ORDER BY id DESC) AS posts LEFT JOIN comments ON posts.id = comments.post_id ORDER BY comments.id desc ``` which retrives `Post<#id 3>`, but `Post<#id 1>` is the one with the latest comment.
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 97.30% 97.32% +0.01%
==========================================
Files 42 43 +1
Lines 3114 3135 +21
==========================================
+ Hits 3030 3051 +21
Misses 84 84
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att