Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sampling from normal distribution in Sink, warn when efficiency is low #560

Open
nuclearkatie opened this issue Nov 28, 2023 · 0 comments

Comments

@nuclearkatie
Copy link
Contributor

Sink can call the PRNG to determine the size of material to request, from 0 to the maximum allowable (throttled by the throughput or total capacity). When using a normal distribution, the mean and standard deviation of those requests are only limited to positive values.

However, this could result in very inefficient calls to the PRNG, resulting in significant numbers of rejected samples.

Could create a warning when the user has chosen an inefficient $\mu$ and $\sigma$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant