Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactor record fuel demand should not be multiplied by n_assem_order #525

Open
jbae11 opened this issue Mar 29, 2021 · 1 comment
Open

Reactor record fuel demand should not be multiplied by n_assem_order #525

jbae11 opened this issue Mar 29, 2021 · 1 comment
Assignees
@jbae11

Comments

@jbae11
Copy link
Contributor

jbae11 commented Mar 29, 2021

In the reactor.cc GetMatlRequests(), the demand recording value should not be multiplied by n_assem_order, since it is inside the for loop. It should be changed to just assem_size.

cycamore/src/reactor.cc

Line 247 in 4bbbd75

assem_size * n_assem_order) ;

@jbae11 jbae11 self-assigned this Mar 29, 2021
@gonuke
Copy link
Member

gonuke commented Apr 7, 2021

Thanks for finding this @jbae11 - look forward to reviewing the PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbae11 jbae11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gonuke @jbae11