Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cycle-scripts-ts-webpack): fix build failing with Typescript 2.1 #51

Merged
merged 1 commit into from
Dec 13, 2016
Merged

fix(cycle-scripts-ts-webpack): fix build failing with Typescript 2.1 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cycle-scripts-ts-webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@types/core-js": "^0.9.34",
"@types/mocha": "^2.2.32",
"@types/node": "^6.0.45",
"awesome-typescript-loader": "^2.2.4",
"awesome-typescript-loader": "^3.0.0-beta",
"chalk": "^1.1.3",
"cross-spawn": "^4.0.2",
"fs-extra": "^0.30.0",
Expand Down
4 changes: 3 additions & 1 deletion cycle-scripts-ts-webpack/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ var path = require('path')
var mkdirp = require('mkdirp')
var webpack = require('webpack')
var ProgressBarPlugin = require('progress-bar-webpack-plugin')
var { CheckerPlugin } = require('awesome-typescript-loader')

var buildPath = path.join(process.cwd(), 'build')
var publicPath = path.join(process.cwd(), 'public')
Expand Down Expand Up @@ -32,7 +33,8 @@ var compiler = webpack({
},
plugins: [
new ProgressBarPlugin(),
new webpack.optimize.UglifyJsPlugin({minimize: true})
new webpack.optimize.UglifyJsPlugin({minimize: true}),
new CheckerPlugin()
]
})

Expand Down
4 changes: 3 additions & 1 deletion cycle-scripts-ts-webpack/scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
var webpack = require('webpack')
var WebpackDevServer = require('webpack-dev-server')
var ProgressBarPlugin = require('progress-bar-webpack-plugin')
var { CheckerPlugin } = require('awesome-typescript-loader')

var host = 'http://localhost'
var port = 8000
Expand Down Expand Up @@ -31,7 +32,8 @@ var config = {
devtool: 'source-map',
plugins: [
new webpack.HotModuleReplacementPlugin(),
new ProgressBarPlugin()
new ProgressBarPlugin(),
new CheckerPlugin()
]
}

Expand Down