Disable endpoint-manager's gc in cilium-agent #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokaze
reviewed
Nov 27, 2024
Signed-off-by: Tomoki Sugiura <[email protected]>
chez-shanpu
force-pushed
the
cilium-endpoint-gc
branch
from
fcadd03
to
81ebb43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"endpoint-manager" which is a subsystem in cilium-agents has GC system.
This GC sometimes removes healthy CEP.
(I think this is due to poor coordination with Coil, but the root cause is not currently known.)
It was implemented as a way to deal with the bug with dockershim.
However, dockershim is not used in Neco and as far as I looked up I cannot find the CEP that has to be garbage collected.
This PR disables endpoint-manager's GC and avoid deleting healthy CEP.