Fix(aws-connector): Limit signing to signed headers from original request #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doodlesbykumbi
force-pushed
the
fix/aws-connector
branch
from
cd7c5f6 to
82e78f0
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
doodlesbykumbi
force-pushed
the
fix/aws-connector
branch
3 times, most recently
from
dbcbc73 to
6971bf6
Compare
diverdane
reviewed
Oct 20, 2021
doodlesbykumbi
force-pushed
the
fix/aws-connector
branch
3 times, most recently
from
caf895f to
8d0bda2
Compare
doodlesbykumbi
force-pushed
the
fix/aws-connector
branch
3 times, most recently
from
5e02e2e to
19baf45
Compare
…uest Prior to this change the AWS connector was signing requests using all the headers present on the original request. This was resulting signature mismatches and failed auth, particularly visible when creating a new s3 bucket. With this change the aws connector will sign only the headers on the original request, it achieves this by temporarily hiding the rest of the headers before signing, then them after signing.
doodlesbykumbi
force-pushed
the
fix/aws-connector
branch
from
136d5a8 to
0bd3002
Compare
|
Code Climate has analyzed commit 0bd3002 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 93.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.8% (1.1% change). View more on Code Climate. |
diverdane
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to this change the AWS connector was signing requests using all the headers present on the original request. This was resulting signature mismatches and failed auth, particularly visible when creating a new s3 bucket. With this change the aws connector will sign only the headers on the original request, it achieves this by temporarily hiding the rest of the headers before signing, then them after signing.
What ticket does this PR close?
Resolves #1430
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs(For releases only) Manual tests