Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'host/' prefix if missing instead of raising error #214

Open
2 tasks
orenbm opened this issue Feb 3, 2021 · 1 comment
Open
2 tasks

Add 'host/' prefix if missing instead of raising error #214

orenbm opened this issue Feb 3, 2021 · 1 comment

Comments

@orenbm
Copy link
Member

orenbm commented Feb 3, 2021

Currently, if the customer forgot to add the host/ prefix to CONJUR_AUTHN_LOGIN we raise the error CONJUR_AUTHN_LOGIN %s must start with 'host/'.

We might do better by adding the prefix by ourselves instead of raising an error. However, we need to further look into it before we make such a change. What if the customer tries to use a user (which is not supported)? in this case we will add host/ to it and it may fail because of some other unexpected behaviour.

We should look into this and decide if this is a good UX enhancement.

DoD:

  • Prefix is added in case it is not present, or
  • A comment is written for why we don't do it
@jtuttle
Copy link
Member

jtuttle commented Oct 1, 2021

I think I would prefer we continue to raise an error here. It's more explicit and doesn't involve any behind-the-scenes modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants